BETA CUDA interface: Address P0 TODOs and cleanups #928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bunch of P0 TODOs:
applyBSF()
now returns a packet, instead of modifying its input in-inplace. This returned packet still needs to be allocated before callingapplyBSF()
, which is slightly un-natural, but needed due to how we defined lifetime of the underlying resources withAutoAVPacket
andReferenceAVPacket
.isFlushing_
member was not needed so it was removed