BETA CUDA interface: properly set NVDEC stream and wait on it #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
changed the title
NicolasHug
commented
Oct 5, 2025
| } else { | ||
| dst = allocateEmptyHWCTensor(frameDims, device_); | ||
| } | ||
|
|
There was a problem hiding this comment.
Note for below: that's introducing yet another dependency relationship between the BETA interface and the default interface. All of this badness is resolved in #931
scotts
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed a bug in #868 a few weeks ago for the default CUDA interface. The problem was that we needed the NPP stream to wait on the NVDEC stream.
This PR makes sure this is done as well for the BETA CUDA interface.