Skip to content

Skip CUDA AV1 tests in fbcode #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+12 −1
Merged

Skip CUDA AV1 tests in fbcode #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion test/test_decoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ def test_get_frame_at_av1(self, device):
if device == "cuda" and get_ffmpeg_major_version() == 4:
return

if device == "cuda" and in_fbcode():
if "cuda" in device and in_fbcode():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the internal issue with CUDA and AV1 isn't new. It's not related to the BETA interface as can be seen here. We were already skipping the AV1 CUDA test for the default interface.

pytest.skip("decoding on CUDA is not supported internally")

decoder = VideoDecoder(AV1_VIDEO.path, device=device)
Expand Down Expand Up @@ -1477,6 +1477,9 @@ def test_beta_cuda_interface_get_frame_at(
if seek_mode == "approximate" and not supports_approximate_mode(asset):
pytest.skip("asset doesn't work with approximate mode")

if in_fbcode() and asset is AV1_VIDEO:
pytest.skip("AV1 CUDA not supported internally")

ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
beta_decoder = VideoDecoder(
asset.path, device="cuda:0:beta", seek_mode=seek_mode
Expand Down Expand Up @@ -1522,6 +1525,8 @@ def test_beta_cuda_interface_get_frames_at(
):
if seek_mode == "approximate" and not supports_approximate_mode(asset):
pytest.skip("asset doesn't work with approximate mode")
if in_fbcode() and asset is AV1_VIDEO:
pytest.skip("AV1 CUDA not supported internally")

ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
beta_decoder = VideoDecoder(
Expand Down Expand Up @@ -1566,6 +1571,8 @@ def test_beta_cuda_interface_get_frames_at(
def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
if seek_mode == "approximate" and not supports_approximate_mode(asset):
pytest.skip("asset doesn't work with approximate mode")
if in_fbcode() and asset is AV1_VIDEO:
pytest.skip("AV1 CUDA not supported internally")

ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
beta_decoder = VideoDecoder(
Expand Down Expand Up @@ -1607,6 +1614,8 @@ def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
if seek_mode == "approximate" and not supports_approximate_mode(asset):
pytest.skip("asset doesn't work with approximate mode")
if in_fbcode() and asset is AV1_VIDEO:
pytest.skip("AV1 CUDA not supported internally")

ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
beta_decoder = VideoDecoder(
Expand Down Expand Up @@ -1649,6 +1658,8 @@ def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
def test_beta_cuda_interface_backwards(self, asset, seek_mode):
if seek_mode == "approximate" and not supports_approximate_mode(asset):
pytest.skip("asset doesn't work with approximate mode")
if in_fbcode() and asset is AV1_VIDEO:
pytest.skip("AV1 CUDA not supported internally")

ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
beta_decoder = VideoDecoder(
Expand Down
Loading