Fix TorchRec inference solution with updated torch.fx + TorchScript Solution #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@PaulZhang12 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
PaulZhang12
added a commit
that referenced
this pull request
Jun 12, 2024
…olution (#2101) Summary: Previously, the TorchRec inference solution used torch.deploy, which isn't supported, and the solution itself was outdated and broken. This PR revamps the inference example with Torch.FX and TorchScript, which more accurately represents what is used in production for RecSys currently. Furthermore, the example was constructed with simplicity as the top priority, with fewer package requirements and steps to run. This is the first iteration of the inference example, with more to come! Pull Request resolved: #2101 Differential Revision: D58478461 Pulled By: PaulZhang12
|
This pull request was exported from Phabricator. Differential Revision: D58478461 |
PaulZhang12
force-pushed
the
inference-fix
branch
from
31c9668 to
6377138
Compare
PaulZhang12
added a commit
that referenced
this pull request
Jun 13, 2024
…olution (#2101) Summary: Previously, the TorchRec inference solution used torch.deploy, which isn't supported, and the solution itself was outdated and broken. This PR revamps the inference example with Torch.FX and TorchScript, which more accurately represents what is used in production for RecSys currently. Furthermore, the example was constructed with simplicity as the top priority, with fewer package requirements and steps to run. This is the first iteration of the inference example, with more to come! Pull Request resolved: #2101 Differential Revision: D58478461 Pulled By: PaulZhang12
PaulZhang12
force-pushed
the
inference-fix
branch
from
6377138 to
a335953
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58478461 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58478461 |
PaulZhang12
added a commit
that referenced
this pull request
Jun 14, 2024
…olution (#2101) Summary: Previously, the TorchRec inference solution used torch.deploy, which isn't supported, and the solution itself was outdated and broken. This PR revamps the inference example with Torch.FX and TorchScript, which more accurately represents what is used in production for RecSys currently. Furthermore, the example was constructed with simplicity as the top priority, with fewer package requirements and steps to run. This is the first iteration of the inference example, with more to come! Pull Request resolved: #2101 Differential Revision: D58478461 Pulled By: PaulZhang12
PaulZhang12
force-pushed
the
inference-fix
branch
from
a335953 to
10cd168
Compare
…olution (#2101) Summary: Previously, the TorchRec inference solution used torch.deploy, which isn't supported, and the solution itself was outdated and broken. This PR revamps the inference example with Torch.FX and TorchScript, which more accurately represents what is used in production for RecSys currently. Furthermore, the example was constructed with simplicity as the top priority, with fewer package requirements and steps to run. This is the first iteration of the inference example, with more to come! Pull Request resolved: #2101 Differential Revision: D58478461 Pulled By: PaulZhang12
|
This pull request was exported from Phabricator. Differential Revision: D58478461 |
PaulZhang12
force-pushed
the
inference-fix
branch
from
10cd168 to
eec5df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the TorchRec inference solution used torch.deploy, which isn't supported, and the solution itself was outdated and broken. This PR revamps the inference example with Torch.FX and TorchScript, which more accurately represents what is used in production for RecSys currently. Furthermore, the example was constructed with simplicity as the top priority, with fewer package requirements and steps to run. This is the first iteration of the inference example, with more to come!