Skip to content

modify the placeholder attr parser to handle dict/list types #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+11 −4
Closed

modify the placeholder attr parser to handle dict/list types #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions torchrec/distributed/train_pipeline/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,16 @@ def _get_node_args_helper(
if child_node.op == "placeholder":
if hasattr(child_node, "ph_key"):
# pyre-ignore[16]
arg_info.input_attrs.insert(0, child_node.ph_key)
arg_info.is_getitems.insert(0, False)
arg_info.preproc_modules.insert(0, None)
ph_key: str = child_node.ph_key
# example: ph_key = 'event_id_list_features_seqs[marketplace]'
ph_keys = ph_key.split("[")
for key in ph_keys:
if "]" in key:
arg_info.input_attrs.append(key[:-1])
arg_info.is_getitems.append(True)
else:
arg_info.input_attrs.append(key)
arg_info.is_getitems.append(False)
else:
# no-op
arg_info.input_attrs.insert(0, "")
Expand Down Expand Up @@ -1038,7 +1045,7 @@ def _rewrite_model( # noqa C901
)

if num_found == total_num_args:
logger.info(f"Module '{node.target}'' will be pipelined")
logger.info(f"Module '{node.target}' will be pipelined")
child = sharded_modules[node.target]
original_forwards.append(child.forward)
child.forward = pipelined_forward(
Expand Down