add DTensor to VLE and fix 2D sharding group in EBC #2626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65555595 |
iamzainhuda
added a commit
to iamzainhuda/torchrec
that referenced
this pull request
Dec 10, 2024
Summary: Adding DTensor state dict to VLE, this is identical to EBC DTensor path. Future work of this diff is to consolidate the logic of EBC/PEA/VLE state dict into one parent class because of their significant similarities A revert diff removed the 2D sharding logic in embedding bag collection mistakenly: D66800554, this diff adds it back in Differential Revision: D65555595
iamzainhuda
force-pushed
the
export-D65555595
branch
from
b2fca7d to
9e744df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65555595 |
Summary: Adding DTensor state dict to VLE, this is identical to EBC DTensor path. Future work of this diff is to consolidate the logic of EBC/PEA/VLE state dict into one parent class because of their significant similarities A revert diff removed the 2D sharding logic in embedding bag collection mistakenly: D66800554, this diff adds it back in Differential Revision: D65555595
iamzainhuda
force-pushed
the
export-D65555595
branch
from
9e744df to
2ecc3ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65555595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding DTensor state dict to VLE, this is identical to EBC DTensor path.
Future work of this diff is to consolidate the logic of EBC/PEA/VLE state dict into one parent class because of their significant similarities
A revert diff removed the 2D sharding logic in embedding bag collection mistakenly: D66800554, this diff adds it back in
Differential Revision: D65555595