Delta Store #3056
Closed
Delta Store #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71130002 |
Summary: # Summary Introducing DeltaStore class which efficiently manages embedding table updates with the following features: * Tracks embedding table updates by table FQN with batch indexing * Supports multiple embedding update modes (NONE, FIRST, LAST) * Provides compaction functionality for calculating unique * Allows retrieval of unique/delta IDs per table with optional embedding values ## How lookups are preserved and fetched? In DeltaStore, lookups are preserved in the `per_fqn_lookups` dictionary, which maps table FQNs to lists of `IndexedLookup` objects. Each `IndexedLookup` contains: 1. `idx`: The batch index 2. `ids`: Tensor of embedding IDs 3. `embeddings`: Optional tensor of embedding values Lookups are added via the `append` method and can be: * Deleted with the `delete` method (up to a specific index) * Compacted with the `compact` method (merges lookups within a range) * Retrieved as unique/delta rows with the `get_delta` method ## This diffs: 1. delta_store.py includes all main logic to preserve, fetch, compact and delete 2. types.py includes required datatypes and enums 3. test_delta_store.py Includes test cases for compute, delete and compact methods Reviewed By: TroyGarden Differential Revision: D71130002
aliafzal
force-pushed
the
export-D71130002
branch
from
0480a9b to
f4530f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71130002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
Introducing DeltaStore class which efficiently manages embedding table updates with the following features:
How lookups are preserved and fetched?
In DeltaStore, lookups are preserved in the
per_fqn_lookupsdictionary, which maps table FQNs to lists ofIndexedLookupobjects. EachIndexedLookupcontains:idx: The batch indexids: Tensor of embedding IDsembeddings: Optional tensor of embedding valuesLookups are added via the
appendmethod and can be:deletemethod (up to a specific index)compactmethod (merges lookups within a range)get_deltamethodThis diffs:
Reviewed By: TroyGarden
Differential Revision: D71130002