refactor: create functions for shard/tensor size calculations #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79007077 |
ashuaibi7
pushed a commit
to ashuaibi7/torchrec
that referenced
this pull request
Aug 5, 2025
…ytorch#3257) Summary: - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: aporialiao Differential Revision: D79007077
ashuaibi7
force-pushed
the
export-D79007077
branch
from
e9661ec to
7fdfa3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79007077 |
ashuaibi7
pushed a commit
to ashuaibi7/torchrec
that referenced
this pull request
Aug 5, 2025
…ytorch#3257) Summary: Pull Request resolved: meta-pytorch#3257 - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: aporialiao Differential Revision: D79007077
ashuaibi7
force-pushed
the
export-D79007077
branch
from
7fdfa3c to
a5d4216
Compare
ashuaibi7
force-pushed
the
export-D79007077
branch
from
a5d4216 to
0ed86a8
Compare
ashuaibi7
pushed a commit
to ashuaibi7/torchrec
that referenced
this pull request
Sep 11, 2025
…ytorch#3257) Summary: - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: levythu, aporialiao Differential Revision: D79007077
|
This pull request was exported from Phabricator. Differential Revision: D79007077 |
ashuaibi7
pushed a commit
to ashuaibi7/torchrec
that referenced
this pull request
Sep 11, 2025
…ytorch#3257) Summary: Pull Request resolved: meta-pytorch#3257 - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: levythu, aporialiao Differential Revision: D79007077
ashuaibi7
force-pushed
the
export-D79007077
branch
2 times, most recently
from
8ca7dbe to
575d4c5
Compare
ashuaibi7
pushed a commit
to ashuaibi7/torchrec
that referenced
this pull request
Sep 12, 2025
…ytorch#3257) Summary: - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: levythu, aporialiao Differential Revision: D79007077
|
@ashuaibi7 has exported this pull request. If you are a Meta employee, you can view the originating diff in D79007077. |
…ytorch#3257) Summary: - refactor to create function for checking if table is cached - refactor to create functions for tensor size calculations Reviewed By: levythu, aporialiao Differential Revision: D79007077
ashuaibi7
force-pushed
the
export-D79007077
branch
from
575d4c5 to
5afb802
Compare
|
@ashuaibi7 has exported this pull request. If you are a Meta employee, you can view the originating diff in D79007077. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D79007077