Delete stub file to enable mypy check #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41028360 |
yhcharles
added a commit
to yhcharles/tnt
that referenced
this pull request
Nov 8, 2022
Summary: X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. Differential Revision: D41028360 fbshipit-source-id: bb21a775019614e4ebcca9dc61872f05e7f3aa7a
yhcharles
force-pushed
the
export-D41028360
branch
from
79dcd45 to
e20a2ea
Compare
yhcharles
added a commit
to yhcharles/torchrec
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 Pull Request resolved: meta-pytorch#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Differential Revision: D41028360 fbshipit-source-id: c272bcc28d2df9477329ed03d5e92b1544b156c4
|
This pull request was exported from Phabricator. Differential Revision: D41028360 |
yhcharles
added a commit
to yhcharles/pytorch
that referenced
this pull request
Nov 9, 2022
Summary: Pull Request resolved: pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Test Plan: CI Differential Revision: D41028360 fbshipit-source-id: 5a19e70a4cfd7070fcbe786d6a31b67a895b2c5b
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 Pull Request resolved: meta-pytorch#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Differential Revision: D41028360 fbshipit-source-id: 6c010352a184790f58cd9730b35e68043de3ca2d
|
This pull request was exported from Phabricator. Differential Revision: D41028360 |
yhcharles
force-pushed
the
export-D41028360
branch
from
e20a2ea to
f375303
Compare
facebook-github-bot
pushed a commit
to meta-pytorch/tnt
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88701 Pull Request resolved: #269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
facebook-github-bot
pushed a commit
to meta-pytorch/torchsnapshot
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 Pull Request resolved: #129 X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
facebook-github-bot
pushed a commit
to facebookresearch/detectron2
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 X-link: meta-pytorch/torchrec#799 Pull Request resolved: #4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
facebook-github-bot
pushed a commit
to facebookresearch/ReAgent
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 Pull Request resolved: #691 X-link: meta-pytorch/torchsnapshot#129 X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
lequytra
pushed a commit
to lequytra/torchrec
that referenced
this pull request
Dec 6, 2022
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 X-link: facebookresearch/ReAgent#691 X-link: meta-pytorch/torchsnapshot#129 Pull Request resolved: meta-pytorch#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
xuruiyang
pushed a commit
to facebookresearch/ReAgent
that referenced
this pull request
Sep 20, 2025
Summary: X-link: pytorch/pytorch#88701 X-link: meta-pytorch/tnt#269 Pull Request resolved: #691 X-link: meta-pytorch/torchsnapshot#129 X-link: meta-pytorch/torchrec#799 X-link: facebookresearch/detectron2#4649 Context in https://fburl.com/4irjskbe This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check. It also helps to fix a lot pyre false alarms, so that we can remove those pyre suppressions. Reviewed By: zhaojuanmao Differential Revision: D41028360 fbshipit-source-id: 577f212ca4c47e23a8577c4b92385c483f96e2c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context in https://fburl.com/4irjskbe
This change deletes distributed.pyi, so that lintrunner will run mypy on distributed.py for typing check.
Differential Revision: D41028360