Allow injecting validators for component verification #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70936713 |
bobyangyf
force-pushed
the
export-D70936713
branch
from
418ad1a to
f9a499a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70936713 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Mar 18, 2025
) Summary: Pull Request resolved: meta-pytorch#1016 So that we can inject logic for verifying pipeline definitions. Currently the verifications are hardcoded to expect appdef Reviewed By: lgarg26 Differential Revision: D70936713
bobyangyf
force-pushed
the
export-D70936713
branch
from
f9a499a to
e750845
Compare
bobyangyf
force-pushed
the
export-D70936713
branch
from
e750845 to
5a93237
Compare
) Summary: Pull Request resolved: meta-pytorch#1016 So that we can inject logic for verifying pipeline definitions. Currently the verifications are hardcoded to expect appdef Reviewed By: lgarg26, manav-a Differential Revision: D70936713
|
This pull request was exported from Phabricator. Differential Revision: D70936713 |
bobyangyf
force-pushed
the
export-D70936713
branch
from
5a93237 to
352b729
Compare
lgarg26
approved these changes
Mar 19, 2025
facebook-github-bot
merged commit d1409e6
into
meta-pytorch:main
18 of 22 checks passed
kausv
pushed a commit
to kausv/torchx
that referenced
this pull request
Jul 17, 2025
Summary: Pull Request resolved: meta-pytorch/tnt#1016 Differential Revision: D78138183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: So that we can inject logic for verifying pipeline definitions. Currently the verifications are hardcoded to expect appdef
Reviewed By: lgarg26
Differential Revision: D70936713