Skip to content

Conversation

kiukchung
Copy link
Contributor

Summary:
Adds a TORCHX_HOME() function to torchx.specs.api (re-exported from torchx/specs/__init__.py for ease of import) that returns the directory path to a ~/.torchx (aka dot-directory) for torchx.

This directory is to be used by torchx to store temporary output such as workspace builds.

Usage:

from torchx.specs import TORCHX_HOME

outdir = TORCHX_HOME("out")

Reviewed By: hstonec

Differential Revision: D83575373

…irectory

Summary:
Adds a `TORCHX_HOME()` function to `torchx.specs.api` (re-exported from `torchx/specs/__init__.py` for ease of import) that returns the directory path to a `~/.torchx` (aka dot-directory) for torchx.

This directory is to be used by torchx to store temporary output such as workspace builds.

Usage:

```
from torchx.specs import TORCHX_HOME

outdir = TORCHX_HOME("out")
```

Reviewed By: hstonec

Differential Revision: D83575373
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83575373.

Copy link
Contributor

@hstonec hstonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (dc79474) to head (9f02760).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
+ Coverage   91.63%   91.64%   +0.01%     
==========================================
  Files          83       83              
  Lines        6394     6402       +8     
==========================================
+ Hits         5859     5867       +8     
  Misses        535      535              
Flag Coverage Δ
unittests 91.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@facebook-github-bot facebook-github-bot merged commit a264c75 into main Sep 30, 2025
18 of 20 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D83575373 branch September 30, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants