Skip to content

Conversation

kiukchung
Copy link
Contributor

Summary:
TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:

Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: https://github.com/pytorch/torchx/issues/120 (404 Client Error: Not Found for url: https://github.com/pytorch/torchx/issues/120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8)
Error: Process completed with exit code 2.

Differential Revision: D83579490

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83579490.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (a264c75) to head (d807383).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          83       83           
  Lines        6402     6402           
=======================================
  Hits         5867     5867           
  Misses        535      535           
Flag Coverage Δ
unittests 91.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…github.com/meta-pytorch/torchx (#1134)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8)
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83579490
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83579490.

@facebook-github-bot facebook-github-bot merged commit 195419b into main Sep 30, 2025
19 of 22 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D83579490 branch September 30, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants