Allow dryrun from cli in JSON launching case #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@ishachirimar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83681938. |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Oct 1, 2025
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
281abae to
f18b3b1
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Oct 1, 2025
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
f18b3b1 to
01dda1a
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Oct 1, 2025
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: daniel-ohayon, nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
01dda1a to
af71641
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Oct 1, 2025
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: daniel-ohayon, nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
af71641 to
20dc963
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 91.66% 91.63% -0.03%
==========================================
Files 83 83
Lines 6427 6431 +4
==========================================
+ Hits 5891 5893 +2
- Misses 536 538 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Oct 2, 2025
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: daniel-ohayon, nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
20dc963 to
ba49841
Compare
Summary: Dryrun is a frequent flag so allow that from CLI Reviewed By: daniel-ohayon, nghuiqin Differential Revision: D83681938
ishachirimar
force-pushed
the
export-D83681938
branch
from
ba49841 to
9c1db3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Dryrun is a frequent flag so allow that from CLI
Differential Revision: D83681938