Skip to content

Do not check torchx.components.base module for components #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not check torchx.components.base module for components #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions torchx/specs/finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,13 @@ def _get_components_from_dir(
search_pattern = os.path.join(search_dir, "**", "*.py")
component_defs = []
for filepath in glob.glob(search_pattern, recursive=True):
module = self._try_load_module(
self._get_module_name(filepath, search_dir, base_module)
)
module_name = self._get_module_name(filepath, search_dir, base_module)
# TODO(aivanou): move `torchx.components.base` to `torchx.specs`, since
# there is nothing related to components in `torchx.components.base`
# see https://github.com/pytorch/torchx/issues/261
if module_name.startswith("torchx.components.base"):
continue
module = self._try_load_module(module_name)
defs = self._get_components_from_module(base_module, module)
component_defs += defs
return component_defs
Expand Down