Skip to content

(torchx/config) remove profiles from .torchxconfig, remove hierarchical loading, and move config loading to cli from runner #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

(torchx/config) remove profiles from .torchxconfig, remove hierarchical loading, and move config loading to cli from runner #260

wants to merge 1 commit into from

Conversation

kiukchung
Copy link
Contributor

Summary:

  1. Removes profiles from .torchxconfig (also removes .cfg suffix from section)
  2. Removes hierarchical loading (only picks up .torchxconfig from CWD - project dir)
  3. Removes config application from runner and moves it to CLI only

Differential Revision: D31674537

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31674537

@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #260 (9162e8e) into main (19925a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          60       60           
  Lines        2767     2767           
=======================================
  Hits         2535     2535           
  Misses        232      232
Impacted Files Coverage Δ
torchx/runner/api.py 96.29% <ø> (-0.06%) ⬇️
torchx/cli/cmd_run.py 89.89% <100.00%> (+0.10%) ⬆️
torchx/runner/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19925a0...9162e8e. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31674537

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31674537

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31674537

@facebook-github-bot
(torchx/config) remove profiles from .torchxconfig, remove hierarchic…
9162e8e 
…al loading, and move config loading to cli from runner (#260)

Summary:
Pull Request resolved: #260

1. Removes profiles from .torchxconfig (also removes .cfg suffix from section)
2. Removes hierarchical loading (only picks up .torchxconfig from CWD - project dir)
3. Removes config application from runner and moves it to CLI only

Reviewed By: d4l3k

Differential Revision: D31674537

fbshipit-source-id: a070eefeefdd56cb54f4e8828de338a19f144c9a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31674537

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 29f1e5e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiukchung @facebook-github-bot