torchx/workspace: workspace_opts + standardize dryrun_push_images and push_images #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 94.97% 94.95% -0.03%
==========================================
Files 68 68
Lines 4659 4676 +17
==========================================
+ Hits 4425 4440 +15
- Misses 234 236 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… push_images (#619) Summary: This makes a few changes intended to make it easier to swap out the workspace implementation for schedulers that support multiple image runtimes. I.e. LSF and Slurm support Docker, Singularity, native, etc * This adds a new `workspace_opts` so we can keep runopts attached to the workspace * This standardizes the `dryrun_push_images` and `push_images` that were used in DockerWorkspace so we can swap the workspace without running into any type issues. Pull Request resolved: #619 Test Plan: Refactor -- no functional changes. Existing tests/CI should suffice Reviewed By: kurman Differential Revision: D40446676 Pulled By: d4l3k fbshipit-source-id: 0e43b159c558991f228bba808f35b9393508d67c
|
This pull request was exported from Phabricator. Differential Revision: D40446676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes intended to make it easier to swap out the workspace implementation for schedulers that support multiple image runtimes. I.e. LSF and Slurm support Docker, Singularity, native, etc
workspace_optsso we can keep runopts attached to the workspacedryrun_push_imagesandpush_imagesthat were used in DockerWorkspace so we can swap the workspace without running into any type issues.Test plan:
Refactor -- no functional changes. Existing tests/CI should suffice