Refactor components discovery logic #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D29202878 |
Summary: Pull Request resolved: meta-pytorch#89 Make torchx compatible with python 3.7 Differential Revision: D29348727 fbshipit-source-id: f033d13559afed83473c6e9caf50ce9c51f4ff01
Summary: Pull Request resolved: meta-pytorch#88 Move component search registration into a separate module and share it across runner and torch_cli Introduce new format for ``[torchx.components]`` : foo = my_project.some_module.bar Where ``my_project.some_module.bar`` is a python module. The components will be recursively found in the dir for ``my_project.some_module.bar.__file__`` file. Reviewed By: kiukchung Differential Revision: D29202878 fbshipit-source-id: ac17e6e597ca3fc92e916e9729d6c16e5c045cb3
aivanou
force-pushed
the
export-D29202878
branch
from
a1788c7 to
66103ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29202878 |
|
This pull request has been merged in 76bb0c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move component search registration into a separate module and share it across runner and torch_cli
Introduce new format for
[torchx.components]:Where
my_project.some_module.baris a python module. The components will be recursively found in the dir formy_project.some_module.bar.__file__file.Reviewed By: kiukchung
Differential Revision: D29202878