Skip to content

Make torchx compatible with python 3.7 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make torchx compatible with python 3.7 #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions torchx/schedulers/slurm_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,15 @@ class SlurmReplicaRequest:
@classmethod
def from_role(cls, role: Role, cfg: RunConfig) -> "SlurmReplicaRequest":
opts = {k: str(v) for k, v in cfg.cfgs.items()}

if (resource := role.resource) != NONE:
if (cpu := resource.cpu) > 0:
opts["cpus-per-task"] = str(cpu)
if (memMB := resource.memMB) > 0:
opts["mem"] = str(memMB)
if (gpu := resource.gpu) > 0:
opts["gpus-per-task"] = str(gpu)
resource = role.resource

if resource != NONE:
if resource.cpu > 0:
opts["cpus-per-task"] = str(resource.cpu)
if resource.memMB > 0:
opts["mem"] = str(resource.memMB)
if resource.gpu > 0:
opts["gpus-per-task"] = str(resource.gpu)

return cls(
dir=role.image,
Expand Down
7 changes: 3 additions & 4 deletions torchx/schedulers/test/slurm_scheduler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,9 @@ def test_run_multi_role(self, run: MagicMock) -> None:
self.assertEqual(app_id, "1234")

self.assertEqual(run.call_count, 1)
self.assertEqual(
run.call_args.kwargs, {"stdout": subprocess.PIPE, "check": True}
)
(args,) = run.call_args.args
args, kwargs = run.call_args
self.assertEqual(kwargs, {"stdout": subprocess.PIPE, "check": True})
(args,) = args
self.assertEqual(len(args), 9)
self.assertEqual(args[:4], ["sbatch", "--parsable", "--job-name", "foo"])
self.assertTrue(args[4].endswith("role-0-a-0.sh"))
Expand Down