Add torchx session id as Environment variable #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66387522 |
yikaiMeta
added a commit
to yikaiMeta/torchx
that referenced
this pull request
Nov 26, 2024
Summary: This diff passes the torchx_session_id as an environment variable. In penv_python, I will fetch this id and log it into logging table. With the session id, it is possible to join the logging table of penv_python with the logging table of torchx. Differential Revision: D66387522
yikaiMeta
force-pushed
the
export-D66387522
branch
from
e4800c7 to
cc0b62e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66387522 |
Summary: This diff passes the torchx_session_id as an environment variable. In penv_python, I will fetch this id and log it into logging table. With the session id, it is possible to join the logging table of penv_python with the logging table of torchx. Reviewed By: tonykao8080 Differential Revision: D66387522
yikaiMeta
force-pushed
the
export-D66387522
branch
from
cc0b62e to
4cc21b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66387522 |
facebook-github-bot
merged commit 648913c
into
meta-pytorch:main
15 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff passes the torchx_session_id as an environment variable.
In penv_python, I will fetch this id and log it into logging table.
With the session id, it is possible to join the logging table of penv_python with the logging table of torchx.
Differential Revision: D66387522