Track unique ids for each scope #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
commented
Jun 12, 2024
| @@ -485,6 +503,21 @@ | |||
| (components (query-fixture :snowflakelet)) | |||
| (components (query-fixture :snowflake)))) | |||
|
|
|||
| (defn sorted-vec | |||
There was a problem hiding this comment.
Oops, doesn't return a vec anymore. All the usage sites compare it to vectors, which works fine, and is why I dropped the explicit conversion. In the next PR I simply rename it to sorted, so think this is OK to slip through.
crisptrutski
commented
Jun 12, 2024
| SELECT | ||
| b.x, | ||
| c.x | ||
| FROM b, c; |
There was a problem hiding this comment.
I add a trailing line-break in a later PR.
crisptrutski
commented
Jun 12, 2024
Comment on lines
+515
to
+516
| (is (=? [{:component {:column "x"}, :scope ["SELECT" (=?/same :subselect-1)]} | ||
| {:component {:column "x"}, :scope ["SELECT" (=?/same :subselect-2)]} |
There was a problem hiding this comment.
I don't think that Hawk will care if these two values are actually the same as each other, or as :top-level, but we certainly do! Maybe we need something new like (=?/unique :blah) which enforces uniqueness across all the captures?
tsmacdonald
reviewed
Jun 13, 2024
| (collect/query->components statement (merge {:preserve-identifiers? true} opts))) | ||
|
|
||
| (defn replace-names | ||
| "Given a SQL query, apply the given table, column, and schema renames. | ||
| "Given an SQL query, apply the given table, column, and schema renames. |
There was a problem hiding this comment.
And now we know that I say "sequel" and you say "ess queue ell" :)
tsmacdonald
approved these changes
Jun 13, 2024
This was referenced Jun 14, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs metabase/metabase#42586
In order to track the provenance of query outputs we will need to follow the flow of data from the source table columns, through the various scopes, to the final top-level expression.
In essence we replace each string label in the in the
:contextvector with a[label, integer-id]pair, so that we can tell when two scopes are the same, and in future use these references to build a DAG of the data dependencies.The test here is very basic, it just checks that our set representation does not de-duplicate the contents of the identical sub-selects. This satisfies the TDD gods1, but isn't that useful on its own.
It'll be superseded when we get to more complex queries, but we're quite a way off from supporting the examples I have in mind.
Footnotes
Actually I lied, and didn't write the test first, and then when I checked I was telling the truth I discovered that they already wouldn't be de-duplicated as Macaw tracks the second CTE's scope as nested within the first one. Well, I still think it's a useful minimal test for establishing which IDs should match and which shouldn't. ↩