-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix column-less aliases resulting in phantom source columns #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
crisptrutski
changed the title
Test for references to column-less aliases not resulting in phantom source columns
Fix column-less aliases not resulting in phantom source columns
Jun 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
crisptrutski
changed the title
Fix column-less aliases not resulting in phantom source columns
Fix column-less aliases resulting in phantom source columns
Jun 19, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on Graphite |
This was referenced Jun 19, 2024
Closed
Closed
crisptrutski
force-pushed
the
with-item-tables
branch
from
June 21, 2024 11:39
a85f77b
to
37e91d8
Compare
crisptrutski
force-pushed
the
test-constant-references
branch
from
June 21, 2024 11:48
4ff87fe
to
4ac8bc1
Compare
Merge activity
|
piranha
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes metabase/metabase#44045
A bit of a mouthful.
The issue was that referring to a non-column alias could result in the Macaw interpreting those references as coming directly from one of the source tables. This was due to the fact that we ignoring aliases that were not introduced by named column references.
Clarifying example:
Without this fix, we would have inferred
{:table "bar" :column "a"}
as a source column.