Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions with joins causes re-run overlay after first save #13468

Closed
flamber opened this issue Oct 14, 2020 · 1 comment · Fixed by #17971
Closed

Questions with joins causes re-run overlay after first save #13468

flamber opened this issue Oct 14, 2020 · 1 comment · Fixed by #17971
Assignees
@kulyk
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.41

Comments

@flamber
Copy link
Contributor

flamber commented Oct 14, 2020

Describe the bug
When creating a question with joins, then after clicking Save, the re-run overlay (Play-button) will be shown.

To Reproduce

  1. Custom question > Sample Dataset > Orders join People and click Visualize
    image
  2. Save question, anywhere, and click "Not now", when asked if the question should be added to a dashboard
  3. Now the re-run overlay is shown, and will run the query again if the Play-button is clicked
    image

Expected behavior
After clicking Save on a question, it's expected to continue to show that state and not requiring re-run of the query again.

Information about your Metabase Installation:
Metabase 0.35.4, 0.36.7, 0.37.0-rc2

Additional context
Add any other context about the problem here.
@flamber flamber added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder labels Oct 14, 2020
nemanjaglumac added a commit that referenced this issue Aug 20, 2021
@nemanjaglumac
Add repro for #13468
2e3942f
@nemanjaglumac nemanjaglumac mentioned this issue Aug 20, 2021
Merged
nemanjaglumac added a commit that referenced this issue Aug 22, 2021
@nemanjaglumac
#13468 Repro: Question with joins causes re-run overlay after first s…
06b50d6 
…ave (#17535)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Aug 22, 2021
@kulyk
Copy link
Member

kulyk commented Sep 20, 2021 •
edited

Can also reproduce the problem with filters

@kulyk kulyk mentioned this issue Sep 20, 2021
Merged
@kulyk kulyk self-assigned this Sep 20, 2021
@flamber flamber added this to the 0.41 milestone Sep 20, 2021
This was referenced Nov 21, 2022
Closed
Closed
This was referenced Nov 28, 2022
Open
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Jan 1, 2023
Closed
1 task
This was referenced Feb 1, 2023
Merged
Merged
This was referenced Feb 26, 2023
Closed
Merged
This was referenced Mar 6, 2023
Merged
Merged
Closed
Merged
Closed
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 15, 2023
Merged
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.41
Development

Successfully merging a pull request may close this issue.

Fix questions with joins or filters cause re-run overlay after first save metabase/metabase
3 participants
@flamber @kulyk @nemanjaglumac