Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results attachment settings for dashboard subscriptions don't persist #14117

Closed
mazameli opened this issue Dec 17, 2020 · 0 comments · Fixed by #14290
Closed

Results attachment settings for dashboard subscriptions don't persist #14117

mazameli opened this issue Dec 17, 2020 · 0 comments · Fixed by #14290
Assignees
@tsmacdonald
Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Milestone
0.38

Comments

@mazameli
Copy link
Contributor

This is on master.

To reproduce

  1. Create a new dashboard and add some questions to it.
  2. Make sure you have SMTP set up.
  3. Click the sharing and embedding button on your dashboard and click on the create new subscription button and pick Email.
  4. Toggle on the attach-results option and pick at least one question whose results you want to attach.
  5. Click Done.
  6. Click on the subscription again and see that your file attachment settings have been lost.

Here's a gif:

https://share.getcloudapp.com/llunEmmb
@mazameli mazameli added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Dashboards labels Dec 17, 2020
@mazameli mazameli added this to the 0.38 milestone Dec 17, 2020
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Dec 22, 2020
nemanjaglumac added a commit that referenced this issue Dec 22, 2020
@nemanjaglumac
Add repro for #14117 [ci skip]
ef6e698
@nemanjaglumac nemanjaglumac mentioned this issue Dec 22, 2020
Merged
nemanjaglumac added a commit that referenced this issue Dec 25, 2020
@nemanjaglumac
#14117 Repro: Dashboard subscriptions don't persist attachments [ci s…
08b402c 
…kip] (#14170)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Dec 25, 2020
@tsmacdonald tsmacdonald mentioned this issue Jan 4, 2021
Closed
11 tasks
@tsmacdonald tsmacdonald mentioned this issue Jan 6, 2021
Merged
tsmacdonald added a commit that referenced this issue Jan 6, 2021
@tsmacdonald
Persist email attachment settings correctly in dashboard subs
260f601 
[Fixes #14117]
tsmacdonald added a commit that referenced this issue Jan 7, 2021
@tsmacdonald
Persist email attachment settings correctly in dashboard subs (#14290)
4d0c282 
* Persist email attachment settings correctly in dashboard subs

[Fixes #14117]
nemanjaglumac added a commit that referenced this issue Jan 7, 2021
@nemanjaglumac
Unskip repro for #14117
47b622f 
The issue was fixed in #14290.
kdoh added a commit that referenced this issue Jan 8, 2021
@kdoh @tsmacdonald @nemanjaglumac
Clean up SharingSidebar data loading (#14283)
54adf85 
* explicitly pass props

* use Pulses.listLoader for fetching pulses [ci skip]

the component lifecycle methods being used to fetch pulses were creating some race
conditions. switching to a listLoader and tweaking the render method helps
clean that up a smidge and prevents the case where we'd have subscriptions to show
but show the new screen anyway.

* remove pulseList usage

* remove use of list-pulses editingMode

* remove unused methods / props

* tweak render logic order

* stub out basic tests

* Fix several bugs related to cancel button behavior in dashboard subscriptions

* Extract SMTP helper function

* Add initial batch of Cypress tests for dashboard subscriptions

* Unskip repro for #14117

The issue was fixed in #14290.

Co-authored-by: Tim Macdonald <tsmacdonald@gmail.com>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
@deploysentinel deploysentinel bot mentioned this issue Dec 16, 2022
Closed
1 task
This was referenced Jan 4, 2023
Closed
Merged
This was referenced Jan 19, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 6, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 24, 2023
Merged
This was referenced Jun 15, 2023
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Jun 23, 2023
Closed
1 task
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Feb 22, 2024
Merged
This was referenced Mar 8, 2024
Merged
Merged
@replay-io replay-io bot mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmacdonald tsmacdonald

Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Backlog
Milestone
0.38
Development

Successfully merging a pull request may close this issue.

Persist email attachment settings correctly in dashboard subs metabase/metabase
3 participants
@tsmacdonald @mazameli @nemanjaglumac