Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data selector popover is too small #15591

Closed
paulrosenzweig opened this issue Apr 13, 2021 · 8 comments
Closed

Data selector popover is too small #15591

paulrosenzweig opened this issue Apr 13, 2021 · 8 comments
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@paulrosenzweig
Copy link
Contributor

image

I'm seeing this on Stats with Chrome.

@paulrosenzweig paulrosenzweig added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend labels Apr 13, 2021
@paulrosenzweig
Copy link
Contributor Author

I called this a P1 since it's such a heavily trafficked path, but it doesn't totally prevent usage of anything so maybe P2 is better. cc @flamber

@flamber
Copy link
Contributor

flamber commented Apr 13, 2021

@paulrosenzweig It is, and I already called it out: #15524 (comment)

@flamber flamber added this to the 0.39 milestone Apr 13, 2021
@flamber flamber added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Apr 13, 2021
@nemanjaglumac
Copy link
Member

nemanjaglumac commented Apr 13, 2021

I can't reproduce this. At least not on release-x.39.x with Chrome in Cypress. Since you're seeing it in stats, is it possible that this issue exists only on master (therefore not blocking 39)?

Btw when I go to stats with Brave, it displays normally for "Simple Question" but I can reproduce it for "Custom Question".

@rlotun rlotun added this to Key Bug fixes (target: 38.4) in 39 and 38.x Planning Board Apr 13, 2021
@flamber
Copy link
Contributor

flamber commented Apr 13, 2021

I can reproduce for Simple and Custom (and Data Model > Segments and Metrics) on 0.39.0-rc2 on Firefox and Chrome with 1920x1080 - I have 17 databases, 31 on stats.
image
image

@howonlee
Copy link
Contributor

I was able to repro and then wasnt after the 15524 so I thought that it fixed this, thanx for deterministic repro

@daltojohnso daltojohnso self-assigned this Apr 13, 2021
@flamber
Copy link
Contributor

flamber commented Apr 13, 2021

Can we also make sure to fix the CE option popover (and binning options, less relevant, since it's smaller) that goes outside of the viewport instead of staying inside with a scroll? As noted in #15524 (comment)

nemanjaglumac added a commit that referenced this issue Apr 13, 2021
nemanjaglumac added a commit that referenced this issue Apr 14, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 14, 2021
@daltojohnso
Copy link
Contributor

fixed by #15608

@nemanjaglumac
Copy link
Member

@daltojohnso there was a repro for this issue that had to be unskipped before the merge.

@rlotun rlotun moved this from Blockers for 39 to Closed Issues and PRs in 39 and 38.x Planning Board Apr 15, 2021
nemanjaglumac added a commit that referenced this issue Apr 15, 2021
nemanjaglumac added a commit that referenced this issue Apr 16, 2021
@flamber flamber removed this from the 0.39 milestone Apr 16, 2021
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
39 and 38.x Planning Board
Closed Issues and PRs
Development

No branches or pull requests

5 participants