Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When fullscreen layers are shown (eg Embedding or Alerts), then it's not possible vertical scroll anymore #15596

Closed
flamber opened this issue Apr 13, 2021 · 2 comments · Fixed by #15621
Closed

When fullscreen layers are shown (eg Embedding or Alerts), then it's not possible vertical scroll anymore #15596

flamber opened this issue Apr 13, 2021 · 2 comments · Fixed by #15621
Assignees
@howonlee
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@flamber
Copy link
Contributor

flamber commented Apr 13, 2021

Describe the bug
When fullscreen layers are shown (eg Embedding or Alerts), then it's not possible vertical scroll anymore. Works in 0.38.4

To Reproduce

  1. Go to a dashboard > click the sharing ↗️ arrow > Sharing and embedding - just close the fullscreen
  2. Go to any page that normally has vertical scroll - Home or troubleshooting Logs - no scrollbars, and cannot use scroll wheel.
  3. Refresh the page, then scroll comes back.

Information about your Metabase Installation:
Tested 0.39.0-rc2 and 1, and 0.38.4
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Apr 13, 2021
@daltojohnso daltojohnso self-assigned this Apr 13, 2021
@nemanjaglumac
Copy link
Member

I lost at least 1h trying to find a way to reproduce this in Cypress, but it seems impossible since cy.window.scrollTo() forces the scroll. In other words, I can reproduce this locally when I personally use the app, but it seems it is not possible to replicate real user behavior in Cypress.

I'll try some more but if anyone else has an idea, I'm all ears.

@flamber
Copy link
Contributor Author

flamber commented Apr 13, 2021

Detect if there's a scrollbar - not sure if you can do that in Cypress, but I have used that for some projects:
https://stackoverflow.com/questions/21064101/understanding-offsetwidth-clientwidth-scrollwidth-and-height-respectively

nemanjaglumac added a commit that referenced this issue Apr 13, 2021
@nemanjaglumac
Add repro for #15596
c05163f
@nemanjaglumac nemanjaglumac mentioned this issue Apr 13, 2021
Merged
@howonlee howonlee assigned howonlee and unassigned daltojohnso Apr 14, 2021
nemanjaglumac added a commit that referenced this issue Apr 14, 2021
@nemanjaglumac
Add repro for #15596
26830d2
nemanjaglumac added a commit that referenced this issue Apr 14, 2021
@nemanjaglumac
#15596 Repro: Not possible to scroll vertically after fullscreen laye…
8384a1c 
…r is closed (#15601)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 14, 2021
howonlee added a commit that referenced this issue Apr 15, 2021
@howonlee
Fullscreen scroll fix #15596 (#15621)
8576dce 
Scrolling gets disabled for the modal and then is supposed to be reenabled when modal is closed. However, SandboxedPortal eats the events that would tell the modal to go and do this. Do it on React lifecycle bits instead.
@flamber flamber linked a pull request Apr 15, 2021 that will close this issue
Fullscreen scroll fix #15596 #15621
Merged
@flamber flamber closed this as completed Apr 15, 2021
This was referenced Jun 15, 2023
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Jun 27, 2023
Merged
1 task
This was referenced Aug 28, 2023
Merged
Merged
Merged
Closed
This was referenced Sep 19, 2023
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howonlee howonlee

Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fullscreen scroll fix #15596 metabase/metabase
4 participants
@howonlee @flamber @daltojohnso @nemanjaglumac