-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Subscription fails, when using dashboard default filter value on Native query with Required parameter #15705
Comments
This comment has been minimized.
This comment has been minimized.
Update: I found that the default filter in the dashboard is being ignored. It only worked when I added a default value in the question itself. |
This comment has been minimized.
This comment has been minimized.
My filter (in the question) was a number. In the dashboard, it had to be "Other Categories", because I am not able to select number directly. Let me try it again: 1- Create question with a number filter |
I think this is BE? It is an issue with variable params specifically--I'm seeing the error message
in the stack trace, but didn't look further than that. Maybe we need to take the |
When loading dashboard filters, the default value is in `:default` not in `:value`. In the field filter code path, the default is copied to `:value`. Fix the issue by calling the same code for non-field filters too. Fixes #15705
When loading dashboard filters, the default value is in `:default` not in `:value`. In the field filter code path, the default is copied to `:value`. Fix the issue by calling the same code for non-field filters too. Fixes #15705
Describe the bug
When sending a subscription email with a default filter set, the question will fail due to the filter not being set.
Logs
Full stacktrace
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The default value should be used in que question.
Screenshots
Dashboard with simple filter and default value:
Subscription settings:
Email generated:
Information about your Metabase Installation:
Severity
High. I have to create artificial workarrounds to make the subscriptions work.
The severity depends on how the acctual subscription will be sent (will update this part as soon as I get an update).If this only happens in the "Send Now" action, this is at least annoying because we cant test subscriptions properly.
The text was updated successfully, but these errors were encountered: