Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection item (from personal collection) selected by checkbox leaves footer action bar open after navigating to some other collection #16491

Closed
nemanjaglumac opened this issue Jun 8, 2021 · 0 comments · Fixed by #21803
Closed

Collection item (from personal collection) selected by checkbox leaves footer action bar open after navigating to some other collection #16491

nemanjaglumac opened this issue Jun 8, 2021 · 0 comments · Fixed by #21803
Assignees
@kulyk
Labels
Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.43

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
I am not able to always reproduce it and cannot figure out what's the cause but it seems to work when the originally selected item is from a personal collection using checkbox. it will leave footer action bar open after navigating to some other collection.

To Reproduce
Steps to reproduce the behavior:

  1. Go to your personal collection (doesn't seem to matter which role do you have)
  2. Select any collection item using the checkbox
  3. See the footer appear with some CTA buttons
  4. Switch to some other collection using the folder tree structure in collection sidebar
  5. Notice the footer is still open

Expected behavior
Footer should immediately close after navigating away from the collection in which one has selected an item using the checkbox.

Screenshots

Information about your Metabase Installation:
local dev, master, 0147a351f5fdebeb2290af1381fe7b0a76aaadc0, but could also reproduce on stats

Severity
P3. Ux.
@flamber flamber added Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage labels Jun 8, 2021
kulyk added a commit that referenced this issue Apr 20, 2022
@kulyk
Reproduce #16491
9baf48d
@kulyk kulyk self-assigned this Apr 20, 2022
@kulyk kulyk mentioned this issue Apr 20, 2022
Merged
kulyk added a commit that referenced this issue Apr 22, 2022
@kulyk
Clean collection items bulk selection when opening another collection (…
6607e4d 
…#21803)

* Reproduce #16491

* Clean bulk selection on collection change
@kulyk kulyk added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 22, 2022
github-actions bot pushed a commit that referenced this issue Apr 22, 2022
@kulyk
Clean collection items bulk selection when opening another collection (…
2c630ab 
…#21803)

* Reproduce #16491

* Clean bulk selection on collection change
@flamber flamber added this to the 0.43 milestone Apr 22, 2022
diogormendes pushed a commit that referenced this issue Apr 22, 2022
@github-actions @kulyk
Clean collection items bulk selection when opening another collection (…
912ac18 
…#21803) (#21907)

* Reproduce #16491

* Clean bulk selection on collection change

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
@deploysentinel deploysentinel bot mentioned this issue Dec 7, 2022
Closed
1 task
@deploysentinel deploysentinel bot mentioned this issue Jan 9, 2023
Closed
1 task
@deploysentinel deploysentinel bot mentioned this issue Jan 31, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 15, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 28, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 7, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue May 16, 2023
Merged
3 tasks
@deploysentinel deploysentinel bot mentioned this issue Jun 14, 2023
Merged
1 task
This was referenced Sep 20, 2023
Closed
Merged
Merged
Closed
Merged
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Sep 27, 2023
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Clean collection items bulk selection when opening another collection metabase/metabase
3 participants
@flamber @kulyk @nemanjaglumac