Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter feature flag causes Run-overlay of results in Native editor unless editor is expanded #16739

Closed
flamber opened this issue Jun 23, 2021 · 0 comments · Fixed by #16850
Closed

Filter feature flag causes Run-overlay of results in Native editor unless editor is expanded #16739

flamber opened this issue Jun 23, 2021 · 0 comments · Fixed by #16850
Assignees
@kulyk
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Milestone
0.40

Comments

@flamber
Copy link
Contributor

flamber commented Jun 23, 2021

Describe the bug
Repeat of #15981.
Filter feature flag causes Run-overlay of results in Native editor unless editor is expanded. Only users with SQL rights are able to expand the editor.

To Reproduce
Filter feature flag is required.

  1. Native query > Sample Dataset > select * from PRODUCTS where {{filter}}
  2. Set variable as Field Filter of Products.Category and filter type to "String"
  3. Run query - notice that the Run button stays active
    image
  4. Collapse the editor - it will now show a Run-overlay, which cannot be removed unless expanding the editor, which isn't possible for all users (depending on permissions).
    image

Information about your Metabase Installation:
Tested 1.39.3 and 1.39.4
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 23, 2021
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Jun 23, 2021
nemanjaglumac added a commit that referenced this issue Jun 24, 2021
@nemanjaglumac
Add repro for #16739
5b1437b
This was referenced Jun 24, 2021
Merged
Closed
nemanjaglumac added a commit that referenced this issue Jun 24, 2021
@nemanjaglumac
#16739 Repro: Filter feature flag causes Run-overlay of results in Na…
a2c07a1 
…tive editor unless editor is expanded (#16753)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 24, 2021
@kulyk kulyk self-assigned this Jun 29, 2021
@flamber flamber mentioned this issue Jun 29, 2021
Closed
kulyk added a commit that referenced this issue Jul 1, 2021
@kulyk
Enable #16739 repro
d56311d
This was referenced Jul 1, 2021
Merged
Merged
@kulyk kulyk mentioned this issue Jul 1, 2021
Merged
kulyk added a commit that referenced this issue Jul 1, 2021
@kulyk
Fix native editor is covered with run-overlay if filter is empty (#16850
12b814a 
)

* Enable #16739 repro

* Fix isResultDirty selector when filter is empty

* Enable repro for #16811
@flamber flamber added this to the 0.40 milestone Jul 1, 2021
nemanjaglumac added a commit that referenced this issue Jul 6, 2021
@nemanjaglumac
Extract repro for #16739 into a separate file
151882c
nemanjaglumac added a commit that referenced this issue Jul 6, 2021
@nemanjaglumac
[SQL filters coverage] Group reproductions (#16898)
6724855 
* Extract repro for #12228 into a separate file

* Extract repro for #15444 into a separate file

* Extract repro for #15460 into a separate file

* Extract repro for #15700 into a separate file

* Extract repro for #15981 into a separate file

* Extract repro for #16739 into a separate file

* Extract repro for #13961 into a separate file

* Extract repro for #14145 into a separate file

* Extract repro for #12581 into a separate file

* Extract repro for #14302 into a separate file

* Extract repro for #15163 into a separate file

* Extract repro for #11580 into a separate file

* Extract repro for #11480 into a separate file

* Extract repro for #9357 into a separate file
@deploysentinel deploysentinel bot mentioned this issue Dec 19, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 21, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Oct 31, 2023
Closed
This was referenced Nov 9, 2023
Merged
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Feb 13, 2024
Merged
@replay-io replay-io bot mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Backlog
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Fix native editor is covered with run-overlay if filter is empty metabase/metabase
3 participants
@flamber @kulyk @nemanjaglumac