-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter flag causes overlay for required "Number" filter with the default value set #16811
Labels
Priority:P2
Average run of the mill bug
Querying/Native
The SQL/native query editor
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
flamber
added
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
Priority:P2
Average run of the mill bug
Querying/Native
The SQL/native query editor
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
and removed
.Needs Triage
labels
Jun 29, 2021
nemanjaglumac
added a commit
that referenced
this issue
Jun 29, 2021
nemanjaglumac
added a commit
that referenced
this issue
Jun 29, 2021
* Add initial set of e2e tests around sql basic filter types - Reproduces #16811 * Add new `filters` e2e group to the CI
This was referenced Mar 24, 2023
This was referenced Oct 18, 2023
Merged
Merged
This was referenced Feb 6, 2024
Open
This was referenced Feb 13, 2024
This was referenced Feb 22, 2024
Merged
This was referenced Mar 5, 2024
This was referenced Mar 15, 2024
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority:P2
Average run of the mill bug
Querying/Native
The SQL/native query editor
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Describe the bug
When feature flag is enabled, and when Number filter is marked as a required but only the default value has been set, it causes overlay to always be shown unless the editor is expanded.
Logs
N/A
To Reproduce
Requires filter feature flag enabled
SELECT * FROM products WHERE products.rating = {{numberFilter}}
4.3
Expected behavior
Running the query should not put question in a "dirty" state and the overlay should not interfere with the results when the editor is collapsed.
Screenshots
Information about your Metabase Installation:
You can get this information by going to Admin -> Troubleshooting.
local dev, x.40.0-snapshot,
master
, 2d890cbSeverity
P2?
The text was updated successfully, but these errors were encountered: