Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a new dashboard from an already open dashboard page suggests random collection #16832

Closed
nemanjaglumac opened this issue Jun 30, 2021 · 0 comments · Fixed by #16853
Closed

Creating a new dashboard from an already open dashboard page suggests random collection #16832

nemanjaglumac opened this issue Jun 30, 2021 · 0 comments · Fixed by #16853
Assignees
@kulyk
Labels
Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
Creating a new dashboard from an already open dashboard page suggests random user's personal collection.

Logs
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Log in as admin
  2. Open any existing dashboard that lives in root ("Our analytics")
  3. Click + to create new dashboard from that page
  4. Notice it offers to save it in some random collection, instead of Our analytics

Expected behavior
Offered collection to save should be the same one as the current dashboard.

Screenshots
Logged in as admin.
image

Information about your Metabase Installation:
local dev, master, x.40.0-snapshot, aa78e38

Severity
P3.
@flamber flamber added .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage labels Jun 30, 2021
kulyk added a commit that referenced this issue Jul 1, 2021
@kulyk
Add repro for #16832
0be205d
@kulyk kulyk mentioned this issue Jul 1, 2021
Merged
kulyk added a commit that referenced this issue Jul 2, 2021
@kulyk
Fix random collection is suggested when saving a new dashboard (#16853)
4ea4b2d 
* Add repro for #16832

* Add `isCollectionPath` URL utility

* Fix getInitialCollectionId uses non-collection IDs

* Handle `location` not starting with a slash
This was referenced Dec 2, 2022
Merged
Closed
@deploysentinel deploysentinel bot mentioned this issue Jan 1, 2023
Closed
1 task
@deploysentinel deploysentinel bot mentioned this issue Jan 31, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 10, 2023
Merged
This was referenced Mar 15, 2023
Merged
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Jun 1, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Dec 5, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Feb 13, 2024
Merged
1 task
@replay-io replay-io bot mentioned this issue Mar 1, 2024
Merged
@replay-io replay-io bot mentioned this issue Apr 4, 2024
Merged
@replay-io replay-io bot mentioned this issue Apr 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Organization/Collections Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix random collection is suggested when saving a new dashboard metabase/metabase
3 participants
@flamber @kulyk @nemanjaglumac