Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions filters does not work in Embedded/Public #17019

Closed
flamber opened this issue Jul 13, 2021 · 0 comments · Fixed by #17032 or #17040
Closed

Questions filters does not work in Embedded/Public #17019

flamber opened this issue Jul 13, 2021 · 0 comments · Fixed by #17032 or #17040
Assignees
@kulyk
Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding Priority:P0 CRITICAL: security holes with clear exploits and regressions that break currently working systems Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.40.1

Comments

@flamber
Copy link
Contributor

flamber commented Jul 13, 2021 •
edited
Loading

Describe the bug
Questions filters does not work in Embedded/Public (it works via dashboards). Regression in 0.40.0

To Reproduce

  1. Native query > Sample Dataset > select {{filter}} - just leave it as Text filter - save question
  2. View via Public Sharing or Embedded with Editable filter
  3. Try to input anything into the filter - it gets reset/removed - no errors in the browser console
Screencast-2021-07-13_18.08.00.mp4

Information about your Metabase Installation:
Metabase 0.40.0
@flamber flamber added Type:Bug Product defects Querying/Parameters & Variables Filter widgets, field filters, variables etc. Priority:P0 CRITICAL: security holes with clear exploits and regressions that break currently working systems Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jul 13, 2021
nemanjaglumac added a commit that referenced this issue Jul 13, 2021
@nemanjaglumac
Add repro for #17019
d147f72
@nemanjaglumac nemanjaglumac mentioned this issue Jul 13, 2021
Merged
nemanjaglumac added a commit that referenced this issue Jul 13, 2021
@nemanjaglumac
#17019 Repro: Question filters don't for for embed/public scenarios (#…
de5f859 
…17024)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jul 13, 2021
kulyk added a commit that referenced this issue Jul 14, 2021
@kulyk
Enable repro for #17019
e5da5c6
@kulyk kulyk self-assigned this Jul 14, 2021
@kulyk kulyk mentioned this issue Jul 14, 2021
Merged
kulyk added a commit that referenced this issue Jul 14, 2021
@kulyk
[P0] Fix filters don't work for public and embedded questions (#17032)
8ac3883 
* Enable repro for #17019

* Fix filters don't work for public questions
kulyk added a commit that referenced this issue Jul 14, 2021
@kulyk
[P0] Fix filters don't work for public and embedded questions (#17032)
21b19bb 
* Enable repro for #17019

* Fix filters don't work for public questions
@kulyk kulyk linked a pull request Jul 14, 2021 that will close this issue
🍒 [P0] Fix filters don't work for public and embedded questions #17040
Merged
@flamber flamber added this to the 0.40.1 milestone Jul 14, 2021
@deploysentinel deploysentinel bot mentioned this issue Dec 19, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 15, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 21, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Dec 1, 2023
Merged
1 task
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding Priority:P0 CRITICAL: security holes with clear exploits and regressions that break currently working systems Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.40.1
3 participants
@flamber @kulyk @nemanjaglumac