-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On master: new restricted domain list doesn't respect 'Send Now' button #17977
Comments
Feature added in #17897. |
Added the backend change and test under #18121. I'm not sure if we'll also want some additional frontend piece to explain what went wrong. With this, the user will just see the button text temporarily change from Send email now to Sending failed (i.e. the current behavior if anything goes wrong with the test send, I suppose). |
Ok, not actually fixed yet. #18122 fixed this for Alerts but not for Dashboard Subscriptions -- this uses a different API endpoint |
Tested manually for dashboard subscriptions "Send now'. It shows "Send failed", and it responds with Do we also want to display the message to the user, like we do when one wants to create a subscription (clicking on the "Done" button)? It feels weird to have it for one case, but not for the other one. |
💯, we should also communicate something to the user in this context. I suspect ideally the code path is the same, right? |
Describe the bug
With the new restricted domains list, I can still send dashboard subscription emails using Send Now to an email address whose domain is not on the list.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It shouldn't sent, and should probably show an error saying 'Domain not allowed, contact administrator' or something to that effect.
This happens on the current master.
The text was updated successfully, but these errors were encountered: