Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select granularity/binning on fields from SQL question, which is joined #18646

Closed
guillaume-chech opened this issue Oct 25, 2021 · 1 comment · Fixed by #21782
Closed
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@guillaume-chech
Copy link

Describe the bug
Chosing between year,quarter, month etc in Custom question group by time dimension is not possible when using joined table.

Logs
No log really just some UI issue.

To Reproduce

  1. Create a custom question with a join
  2. Add an aggregation
  3. Search for a time dimension in the joined table field list
  4. See that you cannot switch from day to month or any other level of detail.

Expected behavior
I would expect to have the level of detail help in the field picker when grouping by a joined table field.

Screenshots

Screenshot 2021-10-25 at 16 10 25

Information about your Metabase Installation:

  • Your browser and the version: Chrome/94.0.4606.81
  • Your operating system: Mac OS X 10_15_7
  • Your databases: Snowflake
  • Metabase version: 1.41.0
  • Metabase hosting environment: Hosted
  • Metabase internal database: PostgreSQL

Severity
Not really blocking as we can invert tables but it's annoying and miss leading to anyone not very tech saavy.

Additional context

@flamber flamber changed the title Chosing between year, month etc in Custom question group by time dimension not possible when using joined table Cannot select granularity/binning on fields from SQL question, which is joined Oct 25, 2021
@flamber flamber added .Frontend Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions and removed .Needs Triage labels Oct 25, 2021
@flamber
Copy link
Contributor

flamber commented Oct 25, 2021

Possibly related to #13764. Seems to only be a problem with joined SQL questions.
Feels like a frontend issue with field dimensions.

Regression since 0.39.0

  1. Native query > Sample Dataset > select * from products - run and save as "Q1"
  2. Custom question > Sample Dataset > Orders
  3. Join "Q1" - already in the join selector, there's not granularity/binning options available to select
    image
  4. Summarize Count grouped by - try selecting any of the fields from the "Q1", no options available
    image

nemanjaglumac added a commit that referenced this issue Oct 25, 2021
nemanjaglumac added a commit that referenced this issue Oct 26, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 26, 2021
github-actions bot pushed a commit that referenced this issue Oct 26, 2021
nemanjaglumac added a commit that referenced this issue Oct 26, 2021
…estion, which is joined (#18661) (#18674)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@flamber flamber added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Nov 5, 2021
@camsaul camsaul assigned camsaul and kulyk and unassigned camsaul Nov 8, 2021
@flamber flamber added this to the 0.43 milestone Apr 21, 2022
@flamber flamber assigned daltojohnso and unassigned kulyk Apr 21, 2022
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
6 participants