-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search results has a box with scrollbars #28788
Labels
.Frontend
Organization/Search
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
paoliniluis
added
Type:Bug
Product defects
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
.Design Needed
Organization/Search
.Frontend
labels
Mar 1, 2023
kamilmielnik
added a commit
that referenced
this issue
Jul 5, 2023
This was referenced Jul 5, 2023
kamilmielnik
added a commit
that referenced
this issue
Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties * Use scrollableHorizontally in table test suite * Take border width into account when computing scrollability * Add an e2e test for #28788 * Remove debugging info * Change "to.not.be" to "not.to.be" to be consistent * Simplify test * Improve the test case as the overflow also can come from the collection description * Fix #28788 * Format test * Replace custom chai assertions with custom helpers
github-actions bot
pushed a commit
that referenced
this issue
Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties * Use scrollableHorizontally in table test suite * Take border width into account when computing scrollability * Add an e2e test for #28788 * Remove debugging info * Change "to.not.be" to "not.to.be" to be consistent * Simplify test * Improve the test case as the overflow also can come from the collection description * Fix #28788 * Format test * Replace custom chai assertions with custom helpers
metabase-bot bot
added a commit
that referenced
this issue
Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties * Use scrollableHorizontally in table test suite * Take border width into account when computing scrollability * Add an e2e test for #28788 * Remove debugging info * Change "to.not.be" to "not.to.be" to be consistent * Simplify test * Improve the test case as the overflow also can come from the collection description * Fix #28788 * Format test * Replace custom chai assertions with custom helpers Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Frontend
Organization/Search
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Describe the bug
Seems like descriptions of questions make the results box bigger than usual, resulting horizontal scrollbars
Logs
NA
To Reproduce
Search for "field filters" in our Metabase instance
Expected behavior
resize the search results box?
Screenshots/videos
Above
Information about your Metabase Installation:
Severity
P3
Additional context
NA
The text was updated successfully, but these errors were encountered: