Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results has a box with scrollbars #28788

Closed
paoliniluis opened this issue Mar 1, 2023 · 0 comments · Fixed by #32139
Closed

Search results has a box with scrollbars #28788

paoliniluis opened this issue Mar 1, 2023 · 0 comments · Fixed by #32139
Assignees
Labels
.Frontend Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@paoliniluis
Copy link
Contributor

paoliniluis commented Mar 1, 2023

Describe the bug
Seems like descriptions of questions make the results box bigger than usual, resulting horizontal scrollbars
image

Logs
NA

To Reproduce
Search for "field filters" in our Metabase instance

Expected behavior
resize the search results box?

Screenshots/videos
Above

Information about your Metabase Installation:

  • Your browser and the version: Brave latest
  • Metabase version: master

Severity
P3

Additional context
NA

@paoliniluis paoliniluis added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Design Needed Organization/Search .Frontend labels Mar 1, 2023
@kamilmielnik kamilmielnik self-assigned this Jul 5, 2023
kamilmielnik added a commit that referenced this issue Jul 5, 2023
@kamilmielnik kamilmielnik added the .Reproduced Issues reproduced in test (usually Cypress) label Jul 5, 2023
kamilmielnik added a commit that referenced this issue Jul 5, 2023
kamilmielnik added a commit that referenced this issue Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties

* Use scrollableHorizontally in table test suite

* Take border width into account when computing scrollability

* Add an e2e test for #28788

* Remove debugging info

* Change "to.not.be" to "not.to.be" to be consistent

* Simplify test

* Improve the test case as the overflow also can come from the collection description

* Fix #28788

* Format test

* Replace custom chai assertions with custom helpers
github-actions bot pushed a commit that referenced this issue Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties

* Use scrollableHorizontally in table test suite

* Take border width into account when computing scrollability

* Add an e2e test for #28788

* Remove debugging info

* Change "to.not.be" to "not.to.be" to be consistent

* Simplify test

* Improve the test case as the overflow also can come from the collection description

* Fix #28788

* Format test

* Replace custom chai assertions with custom helpers
@kamilmielnik kamilmielnik added this to the 0.47 milestone Jul 6, 2023
metabase-bot bot added a commit that referenced this issue Jul 6, 2023
* Add scrollableHorizontally & scrollableVertically chai properties

* Use scrollableHorizontally in table test suite

* Take border width into account when computing scrollability

* Add an e2e test for #28788

* Remove debugging info

* Change "to.not.be" to "not.to.be" to be consistent

* Simplify test

* Improve the test case as the overflow also can come from the collection description

* Fix #28788

* Format test

* Replace custom chai assertions with custom helpers

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Organization/Search Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants