SQL filter gives impression there is no value when you input and then delete the value.

[Tony-metabase]

Describe the bug

Once you setup a filter in an SQL question you need to provide a value else it fails since you are comparing things. If you input a value and remove it then it will work giving the impression the filter is empty where in fact it's taking an empty space.

To Reproduce

1. Go to New Question -> Select * from products Where category = {{test}}
2. Set test filter to a text variable type
3. Follow the following video that shows the inconsistent behaviour when you insert and remove a value form a filter:

Screen.Recording.2023-06-15.at.15.32.03.mov

4. You will notice even though you removed all the values the filter shows like it's empty ... Its filtering for an empty string "" but that is not visible in the filter and shows the name of the Filter as if it's not being used but then there is a x sign which shows there is a value

Expected behavior

Make empty string filtering more intuitive since the filter is not helpful to identify what you are filtering for

Logs

None

Information about your Metabase installation

1.46.5 and master

Severity

minor

Additional context

No response

[uladzimirdev]

@Tony-metabase could you please verify the merged solution? Sorry for I forgot to ping you in advance 😄

[Tony-metabase]

Yep all good :) Sorry for the delay!