Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV appends: append through model page #37220

Merged
merged 3 commits into from Feb 1, 2024

Conversation

calherries
Copy link
Contributor

@calherries calherries commented Jan 3, 2024

This is the feature branch for Merge 2 of 2 of Milestone 0

epic
product doc
eng doc

From eng doc (block link):

User actions:

  • Add data via a CSV file from a model page i.e. …/model/
  • There is a button in the overflow dropdown for the model “Upload data to this model”
  • Clicking on this button opens the file picker
  • The file is uploaded. We show a toasted with status.
  • We show success or error message accordingly.

image

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Jan 3, 2024
@calherries calherries added the no-backport Do not backport this PR to any branch label Jan 3, 2024
Copy link

cypress bot commented Jan 3, 2024

Passing run #1338 ↗︎

0 2199 157 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

CSV appends: Milestone 0, Merge 2 of 2: upload through model page
Project: Metabase e2e Commit: 08ef8e9c5c
Status: Passed Duration: 16:27 💡
Started: Jan 3, 2024 2:21 PM Ended: Jan 3, 2024 2:37 PM

Review all test suite changes for PR #37220 ↗︎

* update upload function to take arguments as an object

* upload to model from context menu

* add e2e tests for appends

* update unit tests

* clean up

* fix types

* ellipsify status title

* don't restrict appends to models on the frontend

* move upload button out of context menu

* automatically show upload error modal

* update tests

* better data fetching and selecting
Copy link

github-actions bot commented Jan 11, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff a862396...6802382.

Notify File(s)
@ranquild frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.tsx
frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.unit.spec.tsx
frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadErrorModal.tsx
frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.stories.tsx
frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.tsx
frontend/src/metabase/status/components/StatusLarge/StatusLarge.styled.tsx
frontend/src/metabase/status/components/StatusLarge/StatusLarge.tsx
frontend/src/metabase/status/components/StatusListing/StatusListing.tsx

Copy link

replay-io bot commented Jan 12, 2024

StatusIn Progress ↗︎ 51 / 52
Commit6802382
Results
⚠️ 3 Flaky
2256 Passed

@calherries calherries merged commit 022201a into master Feb 1, 2024
109 checks passed
@calherries calherries deleted the appends/milestone-0-model-page branch February 1, 2024 19:09
Copy link

github-actions bot commented Feb 1, 2024

@calherries Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

npfitz pushed a commit that referenced this pull request Feb 5, 2024
…7220)

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
@calherries calherries changed the title CSV appends: Milestone 0, Merge 2 of 2: upload through model page CSV appends: upload through model page Feb 7, 2024
@calherries calherries added this to the 0.49 milestone Feb 7, 2024
@calherries calherries changed the title CSV appends: upload through model page CSV appends: append through model page Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants