New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV appends: append through model page #37220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1338 ↗︎
Details:
Review all test suite changes for PR #37220 ↗︎ |
* update upload function to take arguments as an object * upload to model from context menu * add e2e tests for appends * update unit tests * clean up * fix types * ellipsify status title * don't restrict appends to models on the frontend * move upload button out of context menu * automatically show upload error modal * update tests * better data fetching and selecting
Codenotify: Notifying subscribers in CODENOTIFY files for diff a862396...6802382.
|
|
luizarakaki
approved these changes
Feb 1, 2024
@calherries Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
npfitz
pushed a commit
that referenced
this pull request
Feb 5, 2024
…7220) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
calherries
changed the title
CSV appends: Milestone 0, Merge 2 of 2: upload through model page
CSV appends: upload through model page
Feb 7, 2024
calherries
changed the title
CSV appends: upload through model page
CSV appends: append through model page
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch for Merge 2 of 2 of Milestone 0
epic
product doc
eng doc
From eng doc (block link):
User actions: