-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summarizing a model doesn't auto-visualize it unless you first view its query definition #32963
Labels
.Needs Triage
Querying/Models
aka Datasets
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/QueryProcessor
:hammer_and_wrench:
Type:Bug
Product defects
Comments
mazameli
added
Type:Bug
Product defects
.Needs Triage
Querying/Models
aka Datasets
labels
Aug 4, 2023
kulyk
added a commit
that referenced
this issue
Aug 9, 2023
* Reproduce #32963 * Don't lock display for models
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2023
* Reproduce #32963 * Don't lock display for models
kamilmielnik
added a commit
that referenced
this issue
Oct 18, 2023
kamilmielnik
added a commit
that referenced
this issue
Oct 19, 2023
…chill mode only) (#34658) * Update isNavigationAllowed logic to prevent new model creation * Add simple model creation test * Remove identifier * Update comment * Add a test case for saving a new model * Avoid using fetchMock directly in QueryBuilder unit tests * Remove setupCollectionsEndpointsByIds in favor of setupCollectionByIdEndpoint * Add native question test base * Update isNavigationAllowed tests * Make isNavigationAllowed tests pass * Update shouldShowUnsavedChangesWarningForSqlQuery logic to account for new questions * Add a test case to run new native question * Update mock to include individual collection GET endpoint * Add DataSourceSelectors to MockNativeQueryEditor * Update test beforeunload event to reflect new behavior * Use setupCollectionByIdEndpoint instead of modifying setupCollectionsEndpoints * Update failing test * Use serializeCardForUrl * Add a test for native query editing * Do not trigger warning when leaving empty question * Add beforeunload tests for creating new questions * Remove redundant div * Make assertions consistent * Use single resetAllMocks() * Fix post-rebase conflict * Simplify getShouldShowUnsavedChangesWarning's logic * Add isModifiedFromNotebook to store * Show unsaved changes warning when structured question has been modified via notebook editor * Use explicit return type, as it's not obvious that this function needs to be a Promise * Remove unused selector dependency * Update mocks with new attribute * Add a test for editing notebook questions * Extract waitForSaveNewQuestionToBeEnabled out of triggerNotebookQueryChange * Introduce waitForSaveModelToBeEnabled & waitForSaveModelToBeDisabled * Add a test case * Remove redundant navigation * Update isNavigationAllowed logic and tests * Refactor tests and add more test cases * Add more test cases * Shorten code * Add a test for saving the question * Refactor isNavigationAllowed * Add a test for not showing modal * Add a test for non-notebook changes * Organize code * Use existing setUIControls * Add extra assertions for post-save navigation to check if question is properly mark as non-dirty * Add extra assertions for post-save navigation to check if question is properly mark as non-dirty * Add a post-save nagivation test * Add logic to reset UI controls isModifiedFromNotebook state after saving the question * Rename to allowedPathnames * Add explanatory comment * Update failing e2e test * Fix #32963 e2e repro failing * Allow `/model/${slug}` to make models-query-editor e2e test pass * Update isNavigationAllowed logic to make e2e tests pass * Update isNavigationAllowed tests * Add 1 more model location * Revert identifier name change * Use optional chaining operator for brevity * Fix typo * Rename notebook to structured * Rename getQuestionLocations to getNativeQuestionLocations and don't use getNativeQuestionLocations in getStructuredQuestionLocations
This was referenced Jan 11, 2024
Merged
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Needs Triage
Querying/Models
aka Datasets
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/QueryProcessor
:hammer_and_wrench:
Type:Bug
Product defects
Describe the bug
See this bug in action
Summarizing a model from the Summarize sidebar and breaking it out does not correctly exhibit the same auto-visualization-selection behavior that tables do. E.g., summarizing by count and breaking out by a date column should display a line chart, but it instead just displays a table.
The same behavior is seen when opening a model from a collection, then clicking the button to open the notebook editor, then summarizing and breaking out and clicking Visualize.
This behavior is not seen when taking the path of New -> Question -> use a model as data source -> summarize and visualize it.
Also, if you open the model, then open up its query definition view, then cancel, then summarize and break out from the sidebar, the auto visualization selection behavior works correctly.
To Reproduce
See this Loom: https://www.loom.com/share/697c1fee880b4dba87d0691c7a321922
Or
Expected behavior
Summarizing a model should demonstrate the same auto-viz behavior that tables do.
Logs
No response
Information about your Metabase installation
Severity
P1 — it makes models worse than tables in this key way
Additional context
No response
The text was updated successfully, but these errors were encountered: