Field list / filtering / grouping does not work with a native model that has comments

[zbodi74]

Describe the bug

The query builder does not show source fields for models based on native queries, when the query has trailing comments.

To Reproduce

1. Create a native model with the following SQL

select * from products
-- where true=false

make sure there is no trailing space in the last line

2. Create a GUI question based on the model.
3. (!) The field list in the column selector is empty.
4. (!) Summarize and Group also do not offer options with source fields.

Expected behavior

It should work as before.

Logs

2023-10-25 09:08:30,674 DEBUG middleware.log :: POST /api/dataset 202 [ASYNC: completed] 68.9 ms (16 DB calls) App DB connections: 0/15 Jetty threads: 4/50 (6 idle, 0 queued) (125 total active threads) Queries in flight: 0 (0 queued); h2 DB 1 connections: 0/1 (0 threads blocked)
2023-10-25 09:08:30,722 DEBUG middleware.log :: GET /api/database/1 200 2.8 ms (3 DB calls) App DB connections: 0/15 Jetty threads: 5/50 (6 idle, 0 queued) (125 total active threads) Queries in flight: 0 (0 queued)
2023-10-25 09:08:33,864 DEBUG middleware.log :: GET /api/alert/question/9 200 1.3 ms (1 DB calls) App DB connections: 0/15 Jetty threads: 5/50 (6 idle, 0 queued) (125 total active threads) Queries in flight: 0 (0 queued)
2023-10-25 09:09:23,535 INFO api.dataset :: Source query for this query is Card 9
2023-10-25 09:09:23,546 INFO middleware.fetch-source-query :: Trimming trailing comment from card with id 9
2023-10-25 09:09:23,550 INFO middleware.fetch-source-query :: Trimming trailing comment from card with id 9
2023-10-25 09:09:23,554 WARN middleware.add-implicit-clauses :: Warning: cannot determine fields for an explicit `source-query` unless you also include `source-metadata`.
Query: {:native "select * from products\n"}

Information about your Metabase installation

1.47.5

Severity

P1 - it has been reported in the wild. There is a workaround but it is also a loss off common functionality.

Additional context

[ranquild]

@zbodi74 I cannot reproduce in 1.47.5 or in master. Could you please double check the steps?

[oisincoveney]

I'm also unable to reproduce this in 0.47.5 or master.

P1 - it has been reported in the wild. There is a workaround but it is also a loss off common functionality.

@zbodi74 Could you point us where people might be experiencing this? It might help us reproduce the issue more easily

[zbodi74]

@ranquild, @oisincoveney - here is a model that shows the problem: https://stats.metabase.com/collection/1360-gh-35039 .
The error did not occur right after I created the model. I then updated SQL and saved the model a second time, and now it shows the problem.

[uladzimirdev]

I'm not able to reproduce it as well @zbodi74 could you please explain a bit more

I then updated SQL and saved the model a second time, and now it shows the problem.

[zbodi74]

I couldn't figure out why but sometimes the error occurs immediately after I create the model, while other times it appears only after I update and save it for the second time.

[lbrdnk]

I'm able to reproduce on both 1.47.5 and master d419e9a.

Loom with reproduction that seems to show the error reliably also on master.

---

One of the requests made during QB init is GET http://localhost:30034/api/card/<id>. In erroneous case response is missing result_metadata. That's further to be investigated.

[kamilmielnik]

Reopening. Fix will be reverted. See Slack discussion.