special characters on the data will break subscriptions #43677
Assignees
Labels
.Backend
Notifications/Slack
Priority:P1
Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness
Reporting/Pulses
Now called Subscriptions
.Team/DashViz
Dashboard and Viz team
Type:Bug
Product defects
Milestone
Comments
paoliniluis
added
Type:Bug
adam-james-v
added a commit
that referenced
this issue
Jun 21, 2024
WIP Fixes: #43677 There are characters that are invalid according to the Batik XML Parser. This sanitizes the svg string to strip out some of those characters so that the render can continue.
github-automation-metabase
pushed a commit
that referenced
this issue
Jun 24, 2024
…n invalid characters are in the SVG content (#44516) * Add Temporal Units List to Dashboard Parameters Schema Closes: #44361 This adds an entry to the Dashboard Parameter schema so that we can validate the list of temporal_units that might be passed from the frontend when adding or updating the `Unit of Time` type parameters. * Sanitize the SVG before parsing it with Batik WIP Fixes: #43677 There are characters that are invalid according to the Batik XML Parser. This sanitizes the svg string to strip out some of those characters so that the render can continue. * Use the xml 1.0 spec allowed unicode chars list for the regex * Remove accidentally merged code * still miseed a line
github-automation-metabase
added a commit
that referenced
this issue
Jun 24, 2024
…n invalid characters are in the SVG content (#44516) (#44646) * Add Temporal Units List to Dashboard Parameters Schema Closes: #44361 This adds an entry to the Dashboard Parameter schema so that we can validate the list of temporal_units that might be passed from the frontend when adding or updating the `Unit of Time` type parameters. * Sanitize the SVG before parsing it with Batik WIP Fixes: #43677 There are characters that are invalid according to the Batik XML Parser. This sanitizes the svg string to strip out some of those characters so that the render can continue. * Use the xml 1.0 spec allowed unicode chars list for the regex * Remove accidentally merged code * still miseed a line Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Some crazy chars will break the subscriptions since batik can't handle those
To Reproduce
Expected behavior
No response
Logs
Information about your Metabase installation
since the beginningSeverity
P2
Additional context
The text was updated successfully, but these errors were encountered: