Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /account authentication and session deletion behavior #18151

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Sep 30, 2021

Fixes #15471
Fixes #15636

Two related bugs with user authentication.

How to test 1:

  • Logout from Metabase
  • Navigate to /account
  • You should be redirected to the login page

How to test 2:

  • Go to /account/profile
  • Change the password
  • Open top right menu and click "Sign out"
  • You should be redirected to the login page

@ranquild ranquild self-assigned this Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #18151 (fbee4c8) into master (2a48071) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18151      +/-   ##
==========================================
- Coverage   63.92%   63.90%   -0.03%     
==========================================
  Files        1656     1656              
  Lines       67939    67982      +43     
  Branches     7388     7403      +15     
==========================================
+ Hits        43432    43444      +12     
- Misses      21280    21311      +31     
  Partials     3227     3227              
Flag Coverage Δ
front-end 40.79% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/metabase/account/routes.jsx 0.00% <0.00%> (ø)
frontend/src/metabase/auth/auth.js 24.13% <0.00%> (ø)
frontend/src/metabase/lib/auth.js 0.00% <0.00%> (ø)
frontend/src/metabase/routes.jsx 0.00% <ø> (ø)
...rprise/whitelabel/components/ColorSchemeWidget.jsx 0.00% <0.00%> (ø)
...se/query_builder/components/VisualizationError.jsx 40.29% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a48071...fbee4c8. Read the comment docs.

@ranquild ranquild requested a review from a team October 1, 2021 10:15
@ranquild ranquild marked this pull request as ready for review October 1, 2021 10:15
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Oct 1, 2021
@ranquild ranquild merged commit ed4ec6c into master Oct 4, 2021
@ranquild ranquild deleted the 15471-user-routes branch October 4, 2021 11:05
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
2 participants