avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual cards #35545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npretto
added
the
backport
|
No failed tests 🎉 |
deniskaber
approved these changes
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
…irtual cards (#35545) * avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual dashcards * test: adds basic e2e test for text card
ibedwi
pushed a commit
to ibedwi/metabase
that referenced
this pull request
Nov 14, 2023
…irtual cards (metabase#35545) * avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual dashcards * test: adds basic e2e test for text card
alxnddr
pushed a commit
that referenced
this pull request
Nov 15, 2023
…irtual cards (#35545) * avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual dashcards * test: adds basic e2e test for text card
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
Merged
Open
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I definitely did not introduced this bug with my first pull request.
undoRemoveCardFromDashboardrefetches the data for cards, this was added in #32842 to fix a bug with slow queriesI believe this is scope of dash viz, if not please tell me who to ask the review to
Demo
Before:
Screen.Recording.2023-11-09.at.18.06.10.mov
After:
Screen.Recording.2023-11-09.at.18.08.06.mov