[MLv2] Add tests and fix a special case for fk-filter drills #38297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
bshepherdson
added
the
no-backport
Graphite App
|
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-details
branch
from
0edc9dd
to
a1ce933
Compare
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-filter
branch
from
2fe5406
to
a5b4078
Compare
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-details
branch
from
a1ce933
to
28e6e49
Compare
Base automatically changed from
mblib-drills-test-coverage-fk-details
to
master
February 5, 2024 17:12
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-filter
branch
from
a5b4078
to
06255fa
Compare
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-filter
branch
from
06255fa
to
e63e608
Compare
These were not adding an extra stage in order to filter queryies with aggregations. Progress towards #36253.
bshepherdson
force-pushed
the
mblib-drills-test-coverage-fk-filter
branch
from
e63e608
to
d96bf58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not adding an extra stage in order to filter queries with
aggregations.
Progress towards #36253.