Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] New "canned" queries and clicks for drill-thru testing #38210

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[MLv2] New "canned" queries and clicks for drill-thru testing #38210

merged 1 commit into from
Feb 1, 2024

Conversation

bshepherdson
Copy link
Contributor

This also adds a couple of hand-written test cases in addition to
testing the canned set of queries against most of the drills.

Progress towards #36253.

@bshepherdson bshepherdson mentioned this pull request Jan 26, 2024
Closed
@bshepherdson Graphite App
Copy link
Contributor Author

bshepherdson commented Jan 26, 2024 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor(deprecated) Use .Team/Querying instead label Jan 26, 2024
@bshepherdson bshepherdson changed the base branch from mlv2-drills-test-coverage-tracking to master January 26, 2024 20:31
@bshepherdson bshepherdson added this to the 0.49 milestone Jan 26, 2024
@bshepherdson bshepherdson added .Backend no-backport Do not backport this PR to any branch labels Jan 30, 2024 — with Graphite App
@bshepherdson bshepherdson mentioned this pull request Jan 30, 2024
Merged
metamben
metamben approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

test/metabase/lib/drill_thru/test_util/canned.cljc Outdated Show resolved Hide resolved
test/metabase/lib/drill_thru/test_util/canned.cljc Outdated Show resolved Hide resolved
@bshepherdson
[MLv2] New "canned" queries and clicks for drill-thru testing
20b77f5 
This also adds a couple of hand-written test cases in addition to
testing the canned set of queries against most of the drills.

Progress towards #36253.
This was referenced Jan 30, 2024
Merged
Merged
Merged
@bshepherdson bshepherdson enabled auto-merge (squash) January 30, 2024 22:48
@bshepherdson bshepherdson merged commit 2e76d41 into master Feb 1, 2024
109 checks passed
@bshepherdson bshepherdson deleted the mblib-drills-test-coverage branch February 1, 2024 21:32
npfitz pushed a commit that referenced this pull request Feb 5, 2024
@bshepherdson @npfitz
[MLv2] New "canned" queries and clicks for drill-thru testing (#38210)
8857847 
This also adds a couple of hand-written test cases in addition to
testing the canned set of queries against most of the drills.

Progress towards #36253.
@bshepherdson bshepherdson mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metamben metamben metamben approved these changes

@camsaul camsaul Awaiting requested review from camsaul

Assignees

@bshepherdson bshepherdson

Labels
.Backend no-backport Do not backport this PR to any branch .Team/QueryProcessor(deprecated) Use .Team/Querying instead
Projects
None yet
Milestone
0.49
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bshepherdson @metamben