Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] fk-details drill should preserve := filters for other PKs #38296

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

bshepherdson
Copy link
Contributor

That is, if there is a table with multiple PKs, and another table with
multiple FKs for those PKs, then any := filters for other PKs on
that table should be preserved.

This allows using 1 or more quick-filter drills to add FOO_ID = 7 filters
for some of the foreign table's PKs, followed by a fk-details drill that
jumps to the filtered view of that table.

Progress towards #36253.

Copy link

replay-io bot commented Jan 30, 2024

StatusComplete ↗︎
Commita1ce933
Results
⚠️ 2 Flaky
2264 Passed

@darksciencebase darksciencebase added the .Team/QueryProcessor :hammer_and_wrench: label Jan 31, 2024
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshepherdson bshepherdson added this to the 0.49 milestone Feb 2, 2024
@bshepherdson bshepherdson force-pushed the mblib-drills-test-coverage-misc branch from b5866cd to eb30dc9 Compare February 2, 2024 15:46
@bshepherdson bshepherdson force-pushed the mblib-drills-test-coverage-fk-details branch from 0edc9dd to a1ce933 Compare February 2, 2024 15:49
Base automatically changed from mblib-drills-test-coverage-misc to master February 2, 2024 16:23
That is, **if** there is a table with multiple PKs, and another table with
multiple FKs for those PKs, **then** any `:=` filters for other PKs on
that table should be preserved.

This allows using 1 or more quick-filter drills to add `FOO_ID = 7` filters
for some of the foreign table's PKs, followed by a fk-details drill that
jumps to the filtered view of that table.

Progress towards #36253.
@bshepherdson bshepherdson force-pushed the mblib-drills-test-coverage-fk-details branch from a1ce933 to 28e6e49 Compare February 2, 2024 20:04
@bshepherdson bshepherdson enabled auto-merge (squash) February 5, 2024 16:36
@bshepherdson bshepherdson merged commit ea05f6f into master Feb 5, 2024
108 checks passed
@bshepherdson bshepherdson deleted the mblib-drills-test-coverage-fk-details branch February 5, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants