-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLv2] fk-details drill should preserve :=
filters for other PKs
#38296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d50aa6c
to
0edc9dd
Compare
This was referenced Jan 30, 2024
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
metamben
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b5866cd
to
eb30dc9
Compare
0edc9dd
to
a1ce933
Compare
That is, **if** there is a table with multiple PKs, and another table with multiple FKs for those PKs, **then** any `:=` filters for other PKs on that table should be preserved. This allows using 1 or more quick-filter drills to add `FOO_ID = 7` filters for some of the foreign table's PKs, followed by a fk-details drill that jumps to the filtered view of that table. Progress towards #36253.
a1ce933
to
28e6e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if there is a table with multiple PKs, and another table with
multiple FKs for those PKs, then any
:=
filters for other PKs onthat table should be preserved.
This allows using 1 or more quick-filter drills to add
FOO_ID = 7
filtersfor some of the foreign table's PKs, followed by a fk-details drill that
jumps to the filtered view of that table.
Progress towards #36253.