Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] Drill-thru coverage: Add a structured column and fix that case #38295

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bshepherdson
Copy link
Contributor

Most drills don't appear for structured (eg. JSON, XML) columns.

This adds a new canned query and canned clicks for such a column
(by lying in the metadata), then fixes a few test expectations
plus one broken drill.

Progress towards #36253.

Copy link

replay-io bot commented Jan 30, 2024

StatusComplete ↗︎
Commiteb30dc9
Results
⚠️ 3 Flaky
2263 Passed

@darksciencebase darksciencebase added the .Team/QueryProcessor :hammer_and_wrench: label Jan 31, 2024
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/metabase/lib/drill_thru/distribution_test.cljc Outdated Show resolved Hide resolved
test/metabase/lib/drill_thru/quick_filter_test.cljc Outdated Show resolved Hide resolved
@bshepherdson bshepherdson force-pushed the mblib-drills-test-coverage-zoom-in branch 2 times, most recently from 29a2dea to 93c94f8 Compare February 2, 2024 14:49
Base automatically changed from mblib-drills-test-coverage-zoom-in to master February 2, 2024 15:26
@bshepherdson bshepherdson added this to the 0.49 milestone Feb 2, 2024
Most drills don't appear for structured (eg. JSON, XML) columns.

This adds a new canned query and canned clicks for such a column
(by lying in the metadata), then fixes a few test expectations
plus one broken drill.

Progress towards #36253.
@bshepherdson bshepherdson force-pushed the mblib-drills-test-coverage-misc branch from b5866cd to eb30dc9 Compare February 2, 2024 15:46
@bshepherdson bshepherdson merged commit efa166c into master Feb 2, 2024
107 checks passed
@bshepherdson bshepherdson deleted the mblib-drills-test-coverage-misc branch February 2, 2024 16:23
Copy link
Contributor Author

Merge activity

npfitz pushed a commit that referenced this pull request Feb 5, 2024
…#38295)

Most drills don't appear for structured (eg. JSON, XML) columns.

This adds a new canned query and canned clicks for such a column
(by lying in the metadata), then fixes a few test expectations
plus one broken drill.

Progress towards #36253.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants