-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLv2] Drill-thru coverage: Add a structured column and fix that case #38295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
bshepherdson
added
no-backport
Do not backport this PR to any branch
and removed
.Team/QueryProcessor
:hammer_and_wrench:
labels
Jan 30, 2024
— with
Graphite App
This was referenced Jan 30, 2024
|
metamben
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bshepherdson
force-pushed
the
mblib-drills-test-coverage-zoom-in
branch
2 times, most recently
from
February 2, 2024 14:49
29a2dea
to
93c94f8
Compare
Most drills don't appear for structured (eg. JSON, XML) columns. This adds a new canned query and canned clicks for such a column (by lying in the metadata), then fixes a few test expectations plus one broken drill. Progress towards #36253.
bshepherdson
force-pushed
the
mblib-drills-test-coverage-misc
branch
from
February 2, 2024 15:46
b5866cd
to
eb30dc9
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most drills don't appear for structured (eg. JSON, XML) columns.
This adds a new canned query and canned clicks for such a column
(by lying in the metadata), then fixes a few test expectations
plus one broken drill.
Progress towards #36253.