Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing result metadata #39201

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Fix missing result metadata #39201

merged 14 commits into from
Feb 28, 2024

Commits on Feb 26, 2024

  1. Keep result-metadata of native queries if possible 

    Part of #37009.
    @metamben
    metamben committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ddc29af View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @metamben
    metamben committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    34e68e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Add a fallback for when resultMetadata is not available

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5ad3a8b View commit details
    Browse the repository at this point in the history

  2. Revert "Add a fallback for when resultMetadata is not available" 

    This reverts commit 5ad3a8b.
    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1ac94e4 View commit details
    Browse the repository at this point in the history

  3. Move resultsMetadata logic into getSubmittableQuestion

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e53b131 View commit details
    Browse the repository at this point in the history

  4. Add a fallback for when resultMetadata is not available

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9fd4345 View commit details
    Browse the repository at this point in the history

  5. Add explanatory comment

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d465272 View commit details
    Browse the repository at this point in the history

  6. Guard against missing resultsMetadata

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d3b9988 View commit details
    Browse the repository at this point in the history

  7. Add repro for #35039

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e66d812 View commit details
    Browse the repository at this point in the history

  8. Simplify the test

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0b24d1e View commit details
    Browse the repository at this point in the history

  9. Add an explanatory comment

    @kamilmielnik
    kamilmielnik committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8537123 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'master' into 37009-fe-result-metadata

    @kamilmielnik
    kamilmielnik committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7dbfb16 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @kamilmielnik
    kamilmielnik committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f11f6bb View commit details
    Browse the repository at this point in the history

  3. Rename promise to runQuestionPromise

    @kamilmielnik
    kamilmielnik committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    97a2962 View commit details
    Browse the repository at this point in the history