Add CI job for Databricks JDBC #43617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closing as further work now resides in the https://github.com/metabase/metabase/tree/databricks-hive-like branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43497
This PR (1) does cleanup (todos, better implementation of
describe-database) and (2) adjusts the driver so test datasets can be loaded.For reviewer: Please see just the test extensions. I'm asking for a review of that mostly at this stage. At the moment I'm trying to achieve something similar as implemented in Athena. Just loading data in at the moment. Loading works, but I'd like to get feedback on the overall approach -- ie. having Databricks instance with pre loaded databases.
Sidenote: It may later turn out it is not necessary, maybe it would be possible to create "namespace" per run, load and delete afterwards as other drivers do.