Skip to content

rework set_first_release + add first script to tests #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2016
Merged

rework set_first_release + add first script to tests #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions lib/MetaCPAN/Document/Distribution.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,26 +37,19 @@ sub releases {

sub set_first_release {
my $self = shift;
$self->unset_first_release;
my $release = $self->releases->sort( ["date"] )->first;
return unless $release;
return $release if $release->first;
$release->_set_first(1);
$release->put;
return $release;
}

sub unset_first_release {
my $self = shift;
my $releases
= $self->releases->filter( { term => { first => 'true' }, } )
->size(200)->scroll;
while ( my $release = $releases->next ) {
$release->_set_first(0);
$release->update;
my @releases = $self->releases->sort( ["date"] )->all;

my $first = shift @releases;
$first->_set_first(1);
$first->put;

for my $rel (@releases) {
$rel->_set_first(0);
$rel->put;
}
$self->index->refresh if $releases->total;
return $releases->total;

return $first;
}

__PACKAGE__->meta->make_immutable;
Expand Down
4 changes: 0 additions & 4 deletions lib/MetaCPAN/Script/Release.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,6 @@ sub import_archive {
# update 'first' value
$document->set_first;
$document->put;

sleep 2
if defined $ENV{'METACPAN_SERVER_CONFIG_LOCAL_SUFFIX'}
and $ENV{'METACPAN_SERVER_CONFIG_LOCAL_SUFFIX'} eq 'testing';
}

sub _build_backpan_index {
Expand Down
1 change: 1 addition & 0 deletions t/00_setup.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ copy( $src_dir->file('bugs.tsv'), $fakecpan_dir->file('bugs.tsv') );

$server->index_releases;
$server->set_latest;
$server->set_first;
$server->index_authors;
$server->index_cpantesters;

Expand Down
8 changes: 8 additions & 0 deletions t/lib/MetaCPAN/TestServer.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use CPAN::Repository::Perms;
use MetaCPAN::Script::Author;
use MetaCPAN::Script::CPANTesters ();
use MetaCPAN::Script::Latest;
use MetaCPAN::Script::First;
use MetaCPAN::Script::Mapping;
use MetaCPAN::Script::Release;
use MetaCPAN::Server ();
Expand Down Expand Up @@ -184,6 +185,13 @@ sub set_latest {
'latest' );
}

sub set_first {
my $self = shift;
local @ARGV = ('first');
ok( MetaCPAN::Script::First->new_with_options( $self->_config )->run,
'first' );
}

sub index_authors {
my $self = shift;

Expand Down