ArgoCD fixes and App migration #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the leading slash in the `path` field of the ArgoCD application configuration to ensure compatibility with the repository structure. ArgoCD interprets paths with a leading slash as absolute, which can cause sync errors when it fails to locate the specified directory.
Move the Loki ArgoCD Application resource definition to follow the ArgoCD App of Applications pattern.
Move the ArgoCD Application resource definition to follow the ArgoCD App of Applications pattern.
Move the ArgoCD Application resource definition to follow the ArgoCD App of Applications pattern.
haarg
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and migrations to enhance the
maintainability and consistency of our infrastructure:
ArgoCD Application Path Fix: Resolved an issue with ArgoCD by removing the
leading slash in the application path, ensuring compatibility and proper
resource referencing.
Loki, kube-prometheus and kube-thanos Migration: Transitioned applications
to the ArgoCD "App of Apps" pattern, streamlining deployment and improving
scalability.
These changes collectively improve the consistency of our deployment processes
and align with modern GitOps practices.