fix login for non-pause users #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging in as a user that didn't have a PAUSE account connected was working, but the code to fetch the favorites list (which controls the login menu) wasn't interpreting that correctly. The favorites code was checking for a "profile", which only exists for PAUSE users. Instead, use the normal authentication routines and the resulting user object.
|
@haarg I believe do have pause account associated with my profile, so this is probably not a root of the problem. |
|
@haarg The fix is definitely correct one. Though I had my pause account associated with my metacpan account something was wrong in this association, unlinking my pause account and linking it again seem to have fixed the login to the site for me. |
|
@sergeykolychev and @haarg thanks very much to both of you for getting this sorted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging in as a user that didn't have a PAUSE account connected was
working, but the code to fetch the favorites list (which controls the
login menu) wasn't interpreting that correctly. The favorites code was
checking for a "profile", which only exists for PAUSE users.
Instead, use the normal authentication routines and the resulting user
object.
Fixes #1819